[mono][jit] Fix the alignment of stack slots used to pass HFA argumen… #98279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run runtime-ioslike |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 11, 2024
…ts on arm64. Vector3 was assumed to have size 16 and alignment 8, which caused problems when calling llvm compiled methods which assumed it was 12/8. Fixes dotnet#96051. Previously, different sizes/alignment where used in the pinvoke/non-pinvoke cases, causing problems with calling llvm compiled methods which always
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts on arm64.
Vector3 was assumed to have size 16 and alignment 8, which caused problems when calling llvm compiled methods which assumed it was 12/8.
Fixes #96051.
Previously, different sizes/alignment where used in the pinvoke/non-pinvoke cases, causing problems with calling llvm compiled methods which always