Skip to content

Conversation

@eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Feb 14, 2024

Adding a read/write async test that runs with the Windows thread pool enabled.

It also checks that the thread pool IO events are fired correctly, verifying the changes made in #97365.

@eduardo-vp eduardo-vp requested a review from kouvel February 14, 2024 17:37
@ghost ghost assigned eduardo-vp Feb 14, 2024
@ghost
Copy link

ghost commented Feb 14, 2024

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Adding a read/write async test that run with both the Windows and the Portable thread pool.

It also verifies that the events can be fired using either thread pool implementation.

Author: eduardo-vp
Assignees: -
Labels:

area-System.Threading

Milestone: -

Copy link
Contributor

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, just a couple of comments.

Copy link
Contributor

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eduardo-vp eduardo-vp merged commit 5a51e99 into dotnet:main Mar 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
@eduardo-vp eduardo-vp deleted the add-read-async-test branch May 29, 2024 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants