Skip to content

[mono] Fix msvc warning #98568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2024
Merged

[mono] Fix msvc warning #98568

merged 2 commits into from
Feb 16, 2024

Conversation

@fanyang-mono
Copy link
Member

Fix this msvc warning introduced by #98532

D:\a\_work\1\s\src\mono\mono\mini\mini-llvm.c(11638): error C2220: the following warning is treated as an error
  D:\a\_work\1\s\src\mono\mono\mini\mini-llvm.c(11638): warning C4018: '<': signed/unsigned mismatch
  D:\a\_work\1\s\src\mono\mono\mini\mini-llvm.c(11653): warning C4018: '<': signed/unsigned mismatch

@fanyang-mono fanyang-mono requested a review from vargaz as a code owner February 16, 2024 19:09
@ghost ghost assigned fanyang-mono Feb 16, 2024
@fanyang-mono fanyang-mono merged commit efe8b87 into dotnet:main Feb 16, 2024
@build-analysis build-analysis bot mentioned this pull request Feb 17, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@vargaz vargaz Awaiting requested review from vargaz

Assignees

@fanyang-mono fanyang-mono

Labels

area-Codegen-LLVM-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fanyang-mono @steveisok