Skip to content

[browser][MT] Setup tests with blocking .Wait #98802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 36 commits into from
Closed

[browser][MT] Setup tests with blocking .Wait #98802

wants to merge 36 commits into from

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Feb 22, 2024 •
edited
Loading

  • mark blocking tests with PlatformDetection.IsThreadingSupportedAndBlockingWait
  • disable the _XUnitBackgroundExec for the default MT unit tests
    • this means unit tests will get started on Main (deputy) thread
    • disable tests which block on deputy thread via PlatformDetection.IsThreadingSupportedAndBlockingWait
  • add new lane Threading_BackgroundExec to runtime-wasm pipeline
    • which will run the test with PlatformDetection.IsThreadingSupportedAndBlockingWait on thread pool
  • add new lane Threading_BlockingWait to runtime-wasm pipeline
    • which will run the test with PlatformDetection.IsThreadingSupportedAndBlockingWait on deputy but with relaxed blocking restrictions

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Feb 22, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 22, 2024
@pavelsavara pavelsavara self-assigned this Feb 22, 2024
@ghost
Copy link

ghost commented Feb 22, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

  • disable the _XUnitBackgroundExec for the default MT unit tests

    • this means unit tests will get started on Main (deputy) thread
    • disable tests which block on deputy thread via PlatformDetection.IsThreadingSupportedAndBlockingWait

  • add new lane Threading_BackgroundExec to runtime-wasm pipeline

    • which will run the test with PlatformDetection.IsThreadingSupportedAndBlockingWait on thread pool

  • add new lane Threading_BlockingWait to runtime-wasm pipeline

    • which will run the test with PlatformDetection.IsThreadingSupportedAndBlockingWait on deputy but with relaxed blocking restrictions
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-VM-threading-mono, os-browser
Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara
pavelsavara commented Feb 22, 2024
View reviewed changes
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

image

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Mar 5, 2024
Open
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 6, 2024
Closed
3 tasks
@build-analysis build-analysis bot mentioned this pull request Mar 7, 2024
Closed
@maraf maraf self-requested a review March 7, 2024 16:42
@build-analysis build-analysis bot mentioned this pull request Mar 7, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 11, 2024
Open
@build-analysis build-analysis bot mentioned this pull request Mar 12, 2024
Open
@pavelsavara pavelsavara added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
@pavelsavara pavelsavara deleted the backgroud_exec_blocking_wait branch September 2, 2024 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@maraf maraf Awaiting requested review from maraf

Assignees

@pavelsavara pavelsavara

@radekdoulik radekdoulik

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-VM-threading-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara @maraf @radekdoulik @jkotas