Disable terminal logger when running from root build script #99036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the 9.0-preview1 bump the msbuild terminal logger was used again since the option from Directory.Build.rsp was ignored. The reason is that we're using Build.proj from an arcade nuget package so the file isn't in the directory tree above, it looks like it was only working due to an msbuild bug before. Add the -tl:false option into the build scripts directly. Individual invocations of `dotnet build` for repo projects still work because there the Directory.Build.rsp is in the directory tree above.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsSince the 9.0-preview1 SDK bump the msbuild terminal logger was used again since the option from Directory.Build.rsp was ignored. The reason is that we're using Build.proj from an arcade nuget package so the file isn't in the directory tree above, it looks like it was only working due to an msbuild bug before. Add the -tl:false option into the build scripts directly. Individual invocations of See #97211
|
ghost
assigned
ViktorHofer
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the 9.0-preview1 SDK bump the msbuild terminal logger was used again when using the root build.sh/cmd since the option from Directory.Build.rsp was ignored. The reason is that we're calling msbuild on Build.proj from an arcade nuget package so the file isn't in the directory tree above.
Add the -tl:false option into the build scripts directly. Individual invocations of
dotnet buildfor repo projects still work because there the Directory.Build.rsp is in the directory tree above.See #97211