Skip to content

Conversation

@stephentoub
Copy link
Member

Small C# 13 nicety

@ghost ghost added the area-Meta label Mar 13, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@CyrusNajmabadi
Copy link
Member

Yaay :)

@stephentoub
Copy link
Member Author

@kouvel, FYI on the second commit.

@kouvel
Copy link
Contributor

kouvel commented Mar 13, 2024

@kouvel, FYI on the second commit.

Some of the same changes were made by @jjonescz in 374a93f as part of PR #98559 which I thought was bringing in the relevant Roslyn changes. Are you hitting these issues already in the runtime repo? Maybe I missed something, anyway there might be conflicts between the two changes.

@stephentoub
Copy link
Member Author

I hadn't seen that PR. It looks like it's been stalled for a month, and also runs afoul of the versioning discussed above in #99659 (comment). @MichaelSimons,why is that auto-update PR not a problem for source build?

@MichaelSimons
Copy link
Member

@MichaelSimons,why is that auto-update PR not a problem for source build?

It is a potential problem. If there are any dependencies taken on new functionality/breaking changes, it would break source-build. This flow should really only happen monthly.

@danmoseley
Copy link
Member

noticed it's missing from https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/strings/ but don't know how to mark that it's latest C# only.

@stephentoub
Copy link
Member Author

but don't know how to mark that it's latest C# only.

It's still preview (C# 13); we probably don't include preview features in that documentation yet?

@danmoseley
Copy link
Member

It's still preview (C# 13); we probably don't include preview features in that documentation yet?

Oh, I don't know. fine.

@stephentoub
Copy link
Member Author

@lewing, @thaystg, the tests cited in #98559 (comment) are also failing here, which is also trying to bump the Roslyn toolset. If that test isn't failing anywhere else, it would appear it likely is related somehow.

@thaystg
Copy link
Member

thaystg commented Mar 15, 2024

I'm trying to reproduce it locally.

@thaystg
Copy link
Member

thaystg commented Mar 15, 2024

Fixed here: #99824
It was unrelated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Meta NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants