Use a collection expression to assign the IID in GeneratedComInterface-generated code #99734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
huoyaoyuan
reviewed
Mar 14, 2024
| static ExpressionSyntax CreateEmbeddedDataBlobCreationStatement(ReadOnlySpan<byte> bytes) | ||
| { | ||
| var literals = new LiteralExpressionSyntax[bytes.Length]; | ||
| var literals = new CollectionElementSyntax[bytes.Length]; |
There was a problem hiding this comment.
Does this require language version guard?
There was a problem hiding this comment.
Generally, we haven't been adding language version guards in the interop source generators. It's technically more correct to do so, but I'd rather hold off until we have a customer who explicitly downgrades the language version and files an issue with us before I add them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93151