Add Char marshaller #212
Merged
Add Char marshaller #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid supporting the built-in semantics for ANSI marshalling of char. Propagate the CharSet down to the marshallers. Convert the MarshallingGenerators.TryCreate() to a MarshallingGenerators.Create() function throwing an exception.
AaronRobinsonMSFT
added
the
area-DllImportGenerator
elinor-fung
reviewed
Oct 12, 2020
elinor-fung
reviewed
Oct 13, 2020
DllImportGenerator/DllImportGenerator/Marshalling/CharMarshaller.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator.IntegrationTests/CharacterTests.cs
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator.IntegrationTests/CharacterTests.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator.UnitTests/CompileFails.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/Marshalling/MarshallingGenerator.cs
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Oct 14, 2020
50 tasks
jkoritzinsky
pushed a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
* Support for char marshaller. Avoid supporting the built-in semantics for ANSI marshalling of char. Propagate the CharSet down to the marshallers. Convert the MarshallingGenerators.TryCreate() to a MarshallingGenerators.Create() function throwing an exception. * Add a compatibility document. * Add testing for char marshalling. Commit migrated from dotnet/runtimelab@be3f4e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charMarshaller.Avoid supporting the built-in semantics for ANSI marshalling of char.
Propagate the
CharSetdown to the marshallers.Convert the MarshallingGenerators.TryCreate() to a MarshallingGenerators.Create() function throwing an exception.
/cc @jkoritzinsky @elinor-fung