[RuntimeAsync] Rename async2 -> async in JIT and JIT-EE interface #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobbotsch
commented
Apr 8, 2025
| continuation = StubHelpers.AsyncCallContinuation(); | ||
| } | ||
| catch (Exception ex) | ||
| { |
There was a problem hiding this comment.
This document has a number of places where we use "async2" referring to runtime async as opposed to "async1" referring to Task-based Roslyn generated async. I have left those occurrences in.
There was a problem hiding this comment.
Those places are mainly (or only) when describing adapters between runtime async and Task<T>, so perhaps some other terminology would still be better here.
VSadov
reviewed
Apr 8, 2025
VSadov
reviewed
Apr 8, 2025
jakobbotsch
merged commit 8c99af1
into
dotnet:feature/async2-experiment
1 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting back and expanding some changes from dotnet/runtime#113976
cc @VSadov