[RuntimeAsync] Possible way to optimize GetParallelMethodDesc for async (if needed) #3086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSadov
added
* NO MERGE *
VSadov
commented
Apr 14, 2025
| if (!fCanHaveNonVtableSlots || | ||
| it->GetMethodType() == mcInstantiated) | ||
| it->GetMethodType() == mcInstantiated || | ||
| it->GetAsyncMethodKind() != AsyncMethodKind::NotAsync) |
There was a problem hiding this comment.
This would force async/task-returning methods to have real slots. This is the "size" tradeoff.
|
@jakobbotsch - just in case you have questions, thoughts other ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible way to speed up the GetParallelMethodDesc - in most cases switching from linear to constant time.
(where N is the number of methoddescs in a type)
It is a space-for-speed trade that we typically do only for something we need to look up at run time. At JIT time may be not enough reason.
We should know at some point if this is necessary
I am not going to merge this. Just to show that it is possible and what a potential optimization could entail.
(per item
(VM) Optimize MethodTable::GetParallelMethodDescin dotnet/runtime#113976