Add the struct marshalling attributes to Ancillary.Interop and add an analyzer that validates manual usage. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the struct marshalling design doc.
Pull in the Roslyn SDK's test support library to simplify the test setup and ref assembly discovery.
jkoritzinsky
added
the
area-DllImportGenerator
elinor-fung
reviewed
Aug 24, 2020
DllImportGenerator/DllImportGenerator.Test/ManualTypeMarshallingAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator.Test/ManualTypeMarshallingAnalyzerTests.cs
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/ManualTypeMarshallingAnalyzer.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/ManualTypeMarshallingAnalyzer.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/ManualTypeMarshallingAnalyzer.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/ManualTypeMarshallingAnalyzer.cs
Outdated
Show resolved
Hide resolved
DllImportGenerator/DllImportGenerator/ManualTypeMarshallingAnalyzer.cs
Outdated
Show resolved
Hide resolved
…lyzer.cs Co-authored-by: Elinor Fung <[email protected]>
…symbol type doesn't exist.
… features in the analyzer test suite.
Signed-off-by: Jeremy Koritzinsky <[email protected]>
elinor-fung
approved these changes
Aug 31, 2020
| <value>The native type for the type '{0}' is null.</value> | ||
| </data> | ||
| <data name="NativeTypeMustBePointerSizedDescription" xml:space="preserve"> | ||
| <value>The native type must be pointer sized so we can cast the pinned result of 'GetPinnableReference' to the native type.</value> |
There was a problem hiding this comment.
so we can
I prefer avoiding first-person for error/warning messages and descriptions like this.
DllImportGenerator/DllImportGenerator/ManualTypeMarshallingAnalyzer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Elinor Fung <[email protected]>
scalablecory
pushed a commit
that referenced
this pull request
Sep 22, 2020
This PR moves the etwlib to GitHub. Tristan is doing some WPA prototyping with our LTTng events and needs a externally built version of the lib to test it out.
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Sep 20, 2021
… analyzer that validates manual usage. (dotnet/runtimelab#61) Co-authored-by: Elinor Fung <[email protected]> Commit migrated from dotnet/runtimelab@05d6ef2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the struct marshalling attributes discussed in the design doc to Anicllary.Interop.
Adds a Roslyn Analyzer to enable issuing errors/warnings for incorrect usage of these attributes.
Update our test suite to test the analyzer and use the Roslyn SDK test utilities to simplify discovering assemblies to add to our compilations