Fix emitting CodeView information for locals #689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hdr's fields to the PDB file.Note that ordering of special ARM64 registers is different in
cordebuginfo.handcvconst.hfrom DIA SDK:I am not sure we can insert the
ZRregister into theRegNumenumeration incordebuginfo.hwithout creating a potential mess between different .NET versions. For instance, the debugger uses the hard-coded value ofREGNUM_AMBIENT_SP, which would change after the insertion:runtimelab/src/coreclr/debug/inc/dbgipcevents.h
Line 1878 in 3d3b11a
For that reason I handle ARM64's
PCregister separately. Of course,PCis very unlikely to be used for locals, so we might stop atSPinstead.