Skip to content

[main] Update dependencies from dotnet/runtime #17498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 12, 2021
Merged

[main] Update dependencies from dotnet/runtime #17498

merged 7 commits into from
May 12, 2021

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 7, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20210512.4
  • Date Produced: 5/12/2021 6:50 PM
  • Commit: 7ecb1eb17c14e91d510ba58aafa18b69ed62fcb2
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
75e7f50 
…0507.2

Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.5.21256.1 -> To Version 6.0.0-preview.5.21257.2
@ghost
Copy link

ghost commented May 7, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

dotnet-maestro bot added 4 commits May 8, 2021 12:21
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
c53541f 
…0508.2

Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.5.21256.1 -> To Version 6.0.0-preview.5.21258.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
10a5239 
…0508.11

Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.5.21256.1 -> To Version 6.0.0-preview.5.21258.11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
e5d73cd 
…0510.1

Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.5.21256.1 -> To Version 6.0.0-preview.5.21260.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
a998b79 
…0510.8

Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.CodeDom , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.5.21256.1 -> To Version 6.0.0-preview.5.21260.8
@akoeplinger
Copy link
Member

Looks like we have two issues here:

  1. Internal CLR error in Microsoft.NET.Publish.Tests.PublishWpfApp.It_publishes_and_runs_self_contained_wpf_app and Microsoft.NET.Build.Tests.GivenThatWeWantToBuildALibrary.It_fails_gracefully_if_targetframework_is_empty(useSolution: True)
StdErr:
Fatal error. Internal CLR error. (0x80131506)
at System.Collections.Generic.List1+Enumerator[[System.Collections.Generic.KeyValuePair2[[System.Guid, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext()
at System.Collections.Generic.List1[[System.Collections.Generic.KeyValuePair2[[System.Guid, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]..ctor(System.Collections.Generic.IEnumerable1<System.Collections.Generic.KeyValuePair2<System.Guid,System.__Canon>>)
at Microsoft.DotNet.Tools.New.NewCommandShim.CreateHost(Boolean)
at Microsoft.DotNet.Tools.New.NewCommandShim.Run(System.String[])
at Microsoft.DotNet.Cli.Program.ProcessArgs(System.String[], System.TimeSpan, Microsoft.DotNet.Cli.Telemetry.ITelemetry)
at Microsoft.DotNet.Cli.Program.Main(System.String[])

@jkotas @AndyAyersMS any change that jumps out in dotnet/runtime@3897ee5...f511a4a ?

  1. Microsoft.NET.Build.Tests.WorkloadTests.It_should_fail_without_workload and others
C:\h\w\B2850A09\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(109,5):
error NETSDK1139: The target platform identifier missingworkloadtestplatform was not recognized. [C:\h\w\B2850A09\t\dotnetSdkTests\fofmetde.xyi\It_should_fai---8BBAD62A\WorkloadTest\WorkloadTest.csproj]

This one is weird, I don't see anything obvious from dotnet/runtime@3897ee5...f511a4a

@jkotas
Copy link
Member

jkotas commented May 11, 2021

@jkotas @AndyAyersMS any change that jumps out in dotnet/runtime@3897ee5...f511a4a ?

I think it is most likely Andy's change dotnet/runtime#52210

@AndyAyersMS
Copy link
Member

Some detail on what I think is going wrong over in dotnet/runtime#52483. I don't know the crossgen2 type system well enough to take this further.

Seems like for now I'll have to go back to disabling this for prejitting.

@marek-safar
Copy link
Contributor

@marcpopMSFT any ideas why workloads tests could start failing on runtime update?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
9fbfac1 
…0512.1

Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.CodeDom , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.5.21256.1 -> To Version 6.0.0-preview.5.21262.1
@AndyAyersMS AndyAyersMS mentioned this pull request May 12, 2021
Merged
@sfoslund
Copy link
Member

It looks like @dsplaisted added the failing workload tests. They're failing because the target platform identifier is unrecognized but they appear to be looking for a workload not found error message, do you mind taking a look?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
14c3952 
…0512.4

Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.CodeDom , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.5.21256.1 -> To Version 6.0.0-preview.5.21262.4
@dotnet-maestro dotnet-maestro bot merged commit 7f989ee into main May 12, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-9d8732be-f53f-45d4-8a4a-de1b099df008 branch May 12, 2021 22:03
@dsplaisted
Copy link
Member

@sfoslund It looks like this resolved itself, should I still try to look at the errors?

@sfoslund
Copy link
Member

It looks like this resolved itself, should I still try to look at the errors?

No, it's probably fine, thanks!

ViktorHofer pushed a commit that referenced this pull request May 7, 2024
@NikolaMilosavljevic
.NET Source-Build 8.0.100-rc.2.23502.2 October 2023 Updates (#17498)
068e700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@akoeplinger @jkotas @AndyAyersMS @marek-safar @sfoslund @dsplaisted