Skip to content

Improve the example with specified language when language option is given with invalid option #28135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

Improve the example with specified language when language option is given with invalid option #28135

merged 1 commit into from
Oct 13, 2022

Conversation

@GangWang01
Copy link
Member

@GangWang01 GangWang01 commented Sep 23, 2022 •
edited
Loading

Problem

Solution

  • Specified language is added to the example when language option is given together with invalid option.
  • Handle bool option in TemplateOptionResult for handling no template found
  • Expand Cli unit tests.

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@ghost ghost added the Area-Infrastructure label Sep 23, 2022
baronfel
baronfel approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, and I'm very happy to see how easy it is to build command examples with the infrastructure the templating team has put in place. Nice work @GangWang01!

@GangWang01 GangWang01 marked this pull request as ready for review September 26, 2022 05:47
@GangWang01 GangWang01 requested a review from a team as a code owner September 26, 2022 05:47
@vlada-shubina
Copy link
Member

vlada-shubina commented Sep 27, 2022

Agreed to retarget to 7.0.2xx.

@vlada-shubina vlada-shubina added Area-dotnet new the item is related to dotnet new command and removed Area-Infrastructure labels Oct 4, 2022
@vlada-shubina vlada-shubina changed the base branch from release/7.0.1xx to release/7.0.2xx October 4, 2022 11:29
@vlada-shubina
Copy link
Member

vlada-shubina commented Oct 4, 2022

Retargeted to 7.0.2xx

vlada-shubina
vlada-shubina requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the possibility of having other types than bool and string.

@GangWang01 GangWang01 force-pushed the cli-language-example branch from fc7d290 to cd23732 Compare October 10, 2022 03:00
@GangWang01 GangWang01 requested review from vlada-shubina and removed request for JanKrivanek October 10, 2022 03:03
@GangWang01
Copy link
Member Author

GangWang01 commented Oct 10, 2022

@JanKrivanek I accidently removed you from reviewers. Please take a look if you have time.

This was referenced Oct 10, 2022
Closed
Closed
vlada-shubina
vlada-shubina approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you for adding the tests!

@vlada-shubina vlada-shubina merged commit 11bcce2 into dotnet:release/7.0.2xx Oct 13, 2022
@GangWang01 GangWang01 mentioned this pull request Oct 19, 2022
Closed
@GangWang01 GangWang01 deleted the cli-language-example branch December 8, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baronfel baronfel baronfel approved these changes

@vlada-shubina vlada-shubina vlada-shubina approved these changes

Assignees

No one assigned

Labels

Area-dotnet new the item is related to dotnet new command

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GangWang01 @vlada-shubina @baronfel