Add new line to C# item templates with file-scoped namespaces

[DoctorKrolic]

Fixes: dotnet/roslyn#65921 (Does not fix that issue)

Started a new project recently and it was extreamly annoying to add that additional line every single time I create an item. In all codebases I've seen there is always a line break between namespace and type declaration

[vlada-shubina]

@baronfel do you have an opinion on this? the change looks for better to me.

[baronfel]

Yes, this LGTM.

[vlada-shubina]

Thanks

[vlada-shubina]

@YuliiaKovalova let's backport it to 7.0.3xx too.

[DoctorKrolic]

Question from me: Will this affect item templates in Visual Studio? Does it use template engine from this repo?

[JanKrivanek]

It might be good idea to make the same change in project templates as well: https://github.com/dotnet/sdk/tree/8af67162055b50507b5b8743d199828a144275b9/template_feed/Microsoft.DotNet.Common.ProjectTemplates.8.0/content

Long run solution: dotnet/templating#5505

[JanKrivanek]

Question from me: Will this affect item templates in Visual Studio? Does it use template engine from this repo?

Unfortunately not in the current version (VS uses .vstempaltes for those). This should change soon (I cannot comment on the timing/version though)

[YuliiaKovalova]

Question from me: Will this affect item templates in Visual Studio? Does it use template engine from this repo?

The was a discussion about it, but we faced an ambiguity between these project items and already existing ones in VS.
@phenning, do you have any updates here?

[YuliiaKovalova]

It might be good idea to make the same change in project templates as well: https://github.com/dotnet/sdk/tree/8af67162055b50507b5b8743d199828a144275b9/template_feed/Microsoft.DotNet.Common.ProjectTemplates.8.0/content

Long run solution: dotnet/templating#5505

@GangWang01 , could you add these changes?

[GangWang01]

It might be good idea to make the same change in project templates as well: https://github.com/dotnet/sdk/tree/8af67162055b50507b5b8743d199828a144275b9/template_feed/Microsoft.DotNet.Common.ProjectTemplates.8.0/content
Long run solution: dotnet/templating#5505

@GangWang01 , could you add these changes?

@YuliiaKovalova Sure. Made the change in #30972 and #30973.

[phenning]

Question from me: Will this affect item templates in Visual Studio? Does it use template engine from this repo?

The was a discussion about it, but we faced an ambiguity between these project items and already existing ones in VS. @phenning, do you have any updates here?

This is on the backlog, but we don’t have a planned release as of yet for the new templates.

[DoctorKrolic]

Can this be merged? Also if you plan to backport this change to 7.0.3, I assume you'll do it yourselves, right?

[YuliiaKovalova]

Can this be merged? Also if you plan to backport this change to 7.0.3, I assume you'll do it yourselves, right?

Yes, we will port it.

Thank you for your contribution!

[nazarkryp]

you're claiming that this was merged almost year ago, but the problem still persists

[DoctorKrolic]

Unfortunatelly, there are 2 different template engines in .NET CLI and VS. This PR applies to .NET CLI (e.g. dotnet new class), but not to VS. There is no point in keeping a VS issue in any .NET repository since it is internal to VS codebase

[phenning]

I just noticed that the Visual Studio template actually uses a block scope namespace by default:

namespace $rootnamespace$
{
    public class $safeitemrootname$
    {
    }
}

So, it appears that the fixup is being applied by Roslyn after the template's creation does not inject an extra space. Although, this does work as expected with ASP.NET Core projects. I wonder if the fixup is being applied differently between ASP.NET Core and non ASP.NET Core C# projects.