-
Notifications
You must be signed in to change notification settings - Fork 1.2k
One option for fixing the locked file issue in the test #34307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I saw the issue and suggested that updating the BaseIntermediateOutputPath was the best option, IMO.
|
@MiYanni I tried that originally and while it did change the obj directory, it didn't change the bin directory. I wasn't sure if we'd end up with locking files there as that path would still overlap for each of the 8 builds of this project. Copying to a separate directory was the only way to force that. @dsplaisted I didn't see any reusable code for copying the project around. We have CopyTestAssets in our code but that's specific to the structure of the SDK rather than arbitrary assets in other locations. Thoughts? Should we consider moving this test asset into the central SDK story and using that common CopyTestAssets instead? |
For bin, that would be |
|
Chatted with Daniel offline and I'm going to try using the SDK test model of copytestassets to see if that works. Making the templating tests more like the SDK tests seems positive. |
…how other SDK tests manage this
|
Pushed an update to use CopyTestAsset like the rest of the SDK tests do. Let's see if this works for the template tests (worked locally). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
@marcpopMSFT this should be backported to 8.0.1xx to improve test reliability. |
|
/backport to release/8.0.1xx |
1 similar comment
|
/backport to release/8.0.1xx |
|
Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/5881660790 |
|
@marcpopMSFT an error occurred while backporting to release/8.0.1xx, please check the run log for details! Error: @marcpopMSFT is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=marcpopMSFT |
|
/backport to release/8.0.1xx |
|
Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/5881676379 |
Fixes #33956