Skip to content

Conversation

@marcpopMSFT
Copy link
Member

Fixes #33956

@marcpopMSFT marcpopMSFT requested a review from a team as a code owner July 27, 2023 21:10
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Jul 27, 2023
Copy link
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I saw the issue and suggested that updating the BaseIntermediateOutputPath was the best option, IMO.

@marcpopMSFT
Copy link
Member Author

@MiYanni I tried that originally and while it did change the obj directory, it didn't change the bin directory. I wasn't sure if we'd end up with locking files there as that path would still overlap for each of the 8 builds of this project. Copying to a separate directory was the only way to force that.

@dsplaisted I didn't see any reusable code for copying the project around. We have CopyTestAssets in our code but that's specific to the structure of the SDK rather than arbitrary assets in other locations. Thoughts? Should we consider moving this test asset into the central SDK story and using that common CopyTestAssets instead?

@MiYanni
Copy link
Member

MiYanni commented Jul 31, 2023

@MiYanni I tried that originally and while it did change the obj directory, it didn't change the bin directory. I wasn't sure if we'd end up with locking files there as that path would still overlap for each of the 8 builds of this project. Copying to a separate directory was the only way to force that.

For bin, that would be BaseOutputPath. The Intermediate in the former means intermediary build assets, which is typically the obj folder. I'm sure there is likely a more elegant solution, but I'm fine with the one you've created. 👍

@marcpopMSFT
Copy link
Member Author

Chatted with Daniel offline and I'm going to try using the SDK test model of copytestassets to see if that works. Making the templating tests more like the SDK tests seems positive.

@marcpopMSFT
Copy link
Member Author

Pushed an update to use CopyTestAsset like the rest of the SDK tests do. Let's see if this works for the template tests (worked locally).

@marcpopMSFT marcpopMSFT requested a review from MiYanni August 8, 2023 21:13
Copy link
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marcpopMSFT marcpopMSFT merged commit f12cc0c into main Aug 15, 2023
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-testinvestigation branch August 15, 2023 20:23
@marcpopMSFT
Copy link
Member Author

@marcpopMSFT this should be backported to 8.0.1xx to improve test reliability.

@marcpopMSFT
Copy link
Member Author

/backport to release/8.0.1xx

1 similar comment
@marcpopMSFT
Copy link
Member Author

/backport to release/8.0.1xx

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/5881660790

@github-actions
Copy link
Contributor

@marcpopMSFT an error occurred while backporting to release/8.0.1xx, please check the run log for details!

Error: @marcpopMSFT is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=marcpopMSFT

@marcpopMSFT
Copy link
Member Author

/backport to release/8.0.1xx

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/5881676379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File used by another process

3 participants