Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 28, 2023

This pull request updates the following dependencies

From https://github.com/microsoft/vstest

  • Subscription: 37c73770-1170-4c56-4146-08db91e37f87
  • Build: 20231227.1
  • Date Produced: December 28, 2023 9:28:12 AM UTC
  • Commit: 053d7114a72aac12d1382ecc2a23b2dfdd5b084b
  • Branch: refs/heads/rel/17.9

…231227.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23619-01 -> To Version 17.9.0-release-23627-01
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Dec 28, 2023
@Forgind Forgind mentioned this pull request Dec 28, 2023
3 tasks
…231227.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23619-01 -> To Version 17.9.0-release-23627-01
@Forgind
Copy link
Contributor

Forgind commented Dec 29, 2023

@MichalStrehovsky,

The failing tests in this case are It_collects_Aot_publishing_properties and TrimmingOptions_Are_Defaulted_Correctly_On_Aot_Apps

Both tests are failing with NETSDK1102, which you turned on in dotnet/runtime#96206 after saying you'd fixed tests in the SDK repo broken by that change.

Please take a look 🙂

@MichalStrehovsky
Copy link
Member

Please take a look 🙂

I'm on vacation. Someone who broke the main branch should look at this. Looks like the main branch has been on the floor since #37609 merged. The failing tests probably need to pass -p:SelfContained=true but I would start with unbreaking the branch by rolling back the bad commit if I was working.

…231227.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23619-01 -> To Version 17.9.0-release-23627-01
…231227.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23619-01 -> To Version 17.9.0-release-23627-01
…231227.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23619-01 -> To Version 17.9.0-release-23627-01
@dotnet-maestro dotnet-maestro bot merged commit 543c5f2 into main Jan 2, 2024
@dotnet-maestro dotnet-maestro bot deleted the darc-main-9e925586-92fd-4211-87e6-258d88d96ae3 branch January 2, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants