Move Microsoft.DotNet.Tools.Tests.Utilities.Tests into Microsoft.DotNet.Cli.Utils.Tests #40417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…they relied on Microsoft.DotNet.Cli.Utils.csproj. Deleted Microsoft.DotNet.Tools.Tests.Utilities.Tests.csproj since it no longer has any tests. Adjusted InternalsVisibleTo so that the test project builds would function properly.
ghost
added
nagilson
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #38804
Summary
During the Installer repo migration, I realized this repo has a test project called
Microsoft.DotNet.Tools.Tests.Utilities.Tests.csproj. These tests don't actually testMicrosoft.DotNet.Tools.Tests.Utilities.csproj, which is a project that only existed in the Installer repo. This test project actually takes a dependency onMicrosoft.DotNet.Cli.Utils.csproj. Therefore, these tests should be part ofMicrosoft.DotNet.Cli.Utils.Tests.csprojsince they're tests for that assembly.Some
InternalsVisibleTowere necessary for this test project. I've updated those entries toMicrosoft.DotNet.Cli.Utils.Testsnow for the tests to build properly.