Skip to content

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Apr 24, 2024

Related to dotnet/source-build#4357

This is the first step in migrating unified-build and source-build installer pipelines to sdk pipelines.

This PR copies files in installer/eng/pipelines to sdk/eng/pipelines. Also copies installer/eng/vmr-sync.sh and installer/eng/vmr-sync.ps1.

This step allows us to (in future steps):

  1. Create the public pipelines. The public pipelines depend on the ymls being in the public repo.
  2. Update ci.yml and pr.yml to reference sdk/eng/pipelines.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Apr 24, 2024
@ellahathaway
Copy link
Member Author

@ViktorHofer - I've left out the sync logic and related ymls from this PR since I wasn't sure if they would impact builds. Let me know if you think I should include them. Thanks in advance.

@ViktorHofer
Copy link
Member

Just as a general question, do we feel strongly about including history for these files? I'm not sure tbh. cc @MichaelSimons @mmitche

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 25, 2024

@ViktorHofer - I've left out the sync logic and related ymls from this PR since I wasn't sure if they would impact builds. Let me know if you think I should include them. Thanks in advance.

Yeah, we need everything and the files shouldn't impact main until we actually create pipelines, link to the YML and run them.

@mmitche
Copy link
Member

mmitche commented Apr 25, 2024

I don't feel strongly about having the history in sdk.

@ellahathaway ellahathaway marked this pull request as ready for review April 25, 2024 18:04
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straight copy without any modifications, right?

@ellahathaway
Copy link
Member Author

This is a straight copy without any modifications, right?

Correct. I can make the modifications for installer to sdk if we want. Almost all of them are related to the syncing.

@ViktorHofer
Copy link
Member

Let's do the edits in another PR to keep this focused on just the code move. Feel free to merge.

@ellahathaway ellahathaway merged commit 33cc028 into dotnet:feature/installer-merge Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants