Skip to content

Use a crossgen2 that runs on the host for R2Ring in a VMR build #45463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 13, 2025
Merged

Use a crossgen2 that runs on the host for R2Ring in a VMR build #45463

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
269d51a
Re-enable crossgen2 in aspnetcore
jkoritzinsky Dec 13, 2024
ab03d21
Add patches from different repo PRs/branches. Let's see if it works.
jkoritzinsky Dec 13, 2024
4041bfe
Cleanup patch into one unified diff patch and adjust to not conflict …
jkoritzinsky Dec 14, 2024
20f7ec6
Update patches.
jkoritzinsky Dec 16, 2024
3faace4
Reference live RID graph for sfxproj projects in aspnetcore
jkoritzinsky Dec 16, 2024
66e14f5
Update patches
jkoritzinsky Dec 17, 2024
d4b715b
Add an os-only RID into the RID graph to enable the crossgen2 discove…
jkoritzinsky Dec 17, 2024
c32c58a
mark crossgen2 host package as vertical-only
jkoritzinsky Dec 18, 2024
5087892
Update runtime patch
jkoritzinsky Dec 19, 2024
0020f62
Update aspnetcore patch
jkoritzinsky Dec 19, 2024
f8855f2
Update runtime patch
jkoritzinsky Dec 19, 2024
992e3bb
Update aspnetcore patch
jkoritzinsky Dec 19, 2024
ebfa7f4
Merge branch 'main' of github.com:dotnet/sdk into host-crossgen2
jkoritzinsky Dec 20, 2024
72bfd65
Update runtime patch
jkoritzinsky Dec 20, 2024
c8e081b
Merge branch 'main' of github.com:dotnet/sdk into host-crossgen2
jkoritzinsky Jan 10, 2025
c3d62bb
Remove patches as we'll merge this after changes have flowed.
jkoritzinsky Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/SourceBuild/content/repo-projects/aspnetcore.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@

<PropertyGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'">
<BuildArgs>$(BuildArgs) $(FlagParameterPrefix)no-build-repo-tasks</BuildArgs>
<!-- A source-build build can have a separate RID from the SDK that we're building against. This will cause the SDK to not be able to find a crossgen tool pack and fail to R2R: https://github.com/dotnet/source-build/issues/3793 -->
<BuildArgs>$(BuildArgs) /p:CrossgenOutput=false</BuildArgs>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading