Skip to content

Don't consider linux-bionic as a cross-build in UB builds #48549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Don't consider linux-bionic as a cross-build in UB builds #48549

merged 1 commit into from
Apr 17, 2025

Conversation

@jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Apr 17, 2025

Copilot AI review requested due to automatic review settings April 17, 2025 16:26
@jkoritzinsky jkoritzinsky requested review from a team as code owners April 17, 2025 16:26
Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/SourceBuild/patches/runtime/0003-dont-consider-linux-bionic-cross-build.patch: Language not supported

@ghost ghost added the untriaged Request triage from a team member label Apr 17, 2025
@jkoritzinsky jkoritzinsky enabled auto-merge (squash) April 17, 2025 16:33
@akoeplinger
Copy link
Member

akoeplinger commented Apr 17, 2025

Force merge since this isn't tested here and shouldn't affect other jobs.

@akoeplinger akoeplinger disabled auto-merge April 17, 2025 16:50
@akoeplinger akoeplinger merged commit d6673c0 into dotnet:main Apr 17, 2025
20 of 40 checks passed
This was referenced Apr 17, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

Area-VMR untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UB Build failure in Linux-bionic arm/arm64 jobs

3 participants

@jkoritzinsky @akoeplinger @ViktorHofer