Skip to content

Conversation

@tmat
Copy link
Member

@tmat tmat commented Jun 10, 2025

No description provided.

@marcpopMSFT
Copy link
Member

@tmat sounds like you haven't been able to fix the timing out watch tests. Will we need this in some servicing branches as well or should we merge those on red if we hit the watch test timeout?

@tmat
Copy link
Member Author

tmat commented Jun 10, 2025

Will we need this in some servicing branches as well

Not sure. It appears the regression is external to dotnet-watch, but dotnet-watch can handle it better.
The issue is that on Unix web server process doesn't terminate when it's sent SIGTERM.

@tmat tmat marked this pull request as ready for review June 10, 2025 21:04
Copilot AI review requested due to automatic review settings June 10, 2025 21:04
@tmat tmat requested review from a team and arunchndr as code owners June 10, 2025 21:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR marks several known-failing tests as skipped to prevent CI failures while underlying SDK issues are addressed.

  • Adds Skip attributes to hot-reload unit tests referencing issue #49307.
  • Skips a Blazor WebAssembly test in ApplyDeltaTests.
  • Attempts to skip a single InlineData case in a post-action integration test referencing issue #49318.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs Skipped IgnoredChange theory with link to issue #49307
test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs Skipped AutoRestartOnRudeEdit theory and BlazorWasm_Restart fact
test/dotnet-new.IntegrationTests/PostActionTests.cs Added Skip on one InlineData case for issue #49318
Comments suppressed due to low confidence (1)

test/dotnet-new.IntegrationTests/PostActionTests.cs:258

  • The Skip property is not supported on InlineData. To skip this specific case, move the Skip argument to the [Theory] attribute or wrap the test in a conditional skip.
[InlineData("PostActions/RestoreNuGet/Files_PatternWithWildcard", "TestAssets.PostActions.RestoreNuGet.Files_PatternWithWildcard", "Tool.Library/Tool.Library.csproj;Tool.Test/Tool.Test.csproj", "Tool/Tool.csproj", Skip = "https://github.com/dotnet/sdk/issues/49318")]

@marcpopMSFT
Copy link
Member

Merging to unblock other PRs per request

@akoeplinger
Copy link
Member

Not sure. It appears the regression is external to dotnet-watch, but dotnet-watch can handle it better.
The issue is that on Unix web server process doesn't terminate when it's sent SIGTERM.

@tmat This might be related to dotnet/runtime#115494. We reacted to it in aspnetcore in dotnet/aspnetcore#62019 but maybe it needs fixes elsewhere.

@tmat
Copy link
Member Author

tmat commented Jun 11, 2025

Certainly likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants