- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Skip failing dotnet-watch tests #49316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @tmat sounds like you haven't been able to fix the timing out watch tests. Will we need this in some servicing branches as well or should we merge those on red if we hit the watch test timeout? | 
| 
 Not sure. It appears the regression is external to dotnet-watch, but dotnet-watch can handle it better. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR marks several known-failing tests as skipped to prevent CI failures while underlying SDK issues are addressed.
- Adds Skipattributes to hot-reload unit tests referencing issue #49307.
- Skips a Blazor WebAssembly test in ApplyDeltaTests.
- Attempts to skip a single InlineDatacase in a post-action integration test referencing issue #49318.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description | 
|---|---|
| test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs | Skipped IgnoredChangetheory with link to issue #49307 | 
| test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs | Skipped AutoRestartOnRudeEdittheory andBlazorWasm_Restartfact | 
| test/dotnet-new.IntegrationTests/PostActionTests.cs | Added Skipon oneInlineDatacase for issue #49318 | 
Comments suppressed due to low confidence (1)
test/dotnet-new.IntegrationTests/PostActionTests.cs:258
- The Skipproperty is not supported onInlineData. To skip this specific case, move theSkipargument to the[Theory]attribute or wrap the test in a conditional skip.
[InlineData("PostActions/RestoreNuGet/Files_PatternWithWildcard", "TestAssets.PostActions.RestoreNuGet.Files_PatternWithWildcard", "Tool.Library/Tool.Library.csproj;Tool.Test/Tool.Test.csproj", "Tool/Tool.csproj", Skip = "https://github.com/dotnet/sdk/issues/49318")]
| Merging to unblock other PRs per request | 
| 
 @tmat This might be related to dotnet/runtime#115494. We reacted to it in aspnetcore in dotnet/aspnetcore#62019 but maybe it needs fixes elsewhere. | 
| Certainly likely. | 
No description provided.