-
Couldn't load subscription status.
- Fork 1.2k
Add globalJson property for global.json state to toplevelparser/command event #50440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add globalJson property for global.json state to toplevelparser/command event #50440
Conversation
|
@dotnet/dotnet-cli Is there a good way to locally view the telemetry events that actually get sent? I debugged through to make sure the event is created with the new property, but I don't know how to test beyond that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It seems like this is adding a separate event for the global.json state, I'm not sure if that's best or if it would be better to add the global.json state to an existing event.
@baronfel can probably suggest how you can validate the telemetry sent locally.
My intent was to add a property to an existing event ( |
|
@elinor-fung's glomming onto the toplevelparser/command event correctly, it's just a bit weird of a semantic that we have there. I don't really like it, but we haven't revamped it yet. you basically can't easily verify the telemetry locally. when we add Otel that will change and it'll become trivially verifiable, but that won't happen until after 10 GA sometime. |
|
Once a new build comes out we can check the GDPR classifications for this new data point. We'll need to add it to the existing telemetry docs. |
@baronfel I've done the classification. Who owns doing the documentation? |
|
@marcpopMSFT logged dotnet/docs#48493 to track the new data point |
Including the state of
global.jsonin telemetry events for SDK commands.hostfxrbindings forhostfxr_resolve_sdk2for global.json state added in Report invalid global.json state indotnet --infoandhostfxr_resolve_sdk2runtime#118418hostfxrto determine global.json state per Add telemetry for invalid global.json when running a command #50058 (comment)globalJsonproperty intoplevelparser/commandeventResolves #50058
cc @dotnet/appmodel @AaronRobinsonMSFT @richlander