Fix process framework references crash when null RID is passed #50682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Sep 8, 2025
baronfel
commented
Sep 8, 2025
src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs
Outdated
Show resolved
Hide resolved
baronfel
commented
Sep 8, 2025
baronfel
commented
Sep 8, 2025
joeloff
reviewed
Sep 8, 2025
src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Sep 8, 2025
joeloff
approved these changes
Sep 8, 2025
nagilson
reviewed
Sep 8, 2025
src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs
Outdated
Show resolved
Hide resolved
dsplaisted
approved these changes
Sep 8, 2025
definitely - working on boosting coverage of this Task right now. Copilot's doing a great job helping synthesize some test cases. |
baronfel
force-pushed
the
fix-process-framework-references-ridless-crash
branch
from
ee40d57 to
bbb2c31
Compare
|
Added a bunch of additional test coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50680
This looks like a regression caused by #50455 - clearly we have some testing gaps.
If this Target ever executes in a context where no single-RID is specified, some RID-specific assets shouldn't be processed for that single-RID. Instead, processing for any passed-in RIDs should wait until the part of the processing where all of the
RuntimeIdentifiersare iterated over.To make this easier to see/check, I enabled nullability for this Target and supporting logic.