-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove dnx.ps1 #51120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dnx.ps1 #51120
Conversation
/ba-g GenerateBundle known issue |
This LGTM but we need to get Tactics approval |
@dotnet/dotnet-docker-admin this PR would remove the |
It's easy to remove it. dotnet-docker's PR validation should fail whenever the change flows in, at which point we can just revert the change. |
Added When you commit this breaking change:
You can refer to the .NET SDK breaking change guidelines |
Breaking change doc issue created: dotnet/docs#49044 |
See #51067. The .ps1 script prevents the CLI from correctly processing
--
. So we'll remove the script, This will regress to the "terminate batch job" behavior described in #49623, but that's better than incorrectly processing command line arguments.Description
Removes dnx.ps1 helper script.
Customer impact
Fixes processing of
--
when calling dnx from PowerShell.Brings back "Terminate Batch Job" prompt when CTRL+C is pressed, but this is preferrable to incorrectly processing the command line.
Regression
dnx
is new in .NET 10. This was a regression from a previous preview release.Risk
Low