Skip to content

Conversation

@lonitra
Copy link
Member

@lonitra lonitra commented Aug 9, 2024

Related to #11847

Regression was introduced in #10319 because we had removed a condition to check whether drag image is present. Re-adding that conditional the PR originally took out in DropSource. I checked this issue is fixed and the issue linked PR resolved remains fixed.

Microsoft Reviewers: Open in CodeFlow

@lonitra lonitra requested a review from a team as a code owner August 9, 2024 23:40
@lonitra lonitra enabled auto-merge (squash) August 9, 2024 23:43
@codecov
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.84616%. Comparing base (d7c8152) to head (0a2b262).

❗ There is a different number of reports uploaded between BASE (d7c8152) and HEAD (0a2b262). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (d7c8152) HEAD (0a2b262)
Debug 3 2
test 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #11853          +/-   ##
====================================================
- Coverage   74.84593%   47.84616%   -26.99977%     
====================================================
  Files           3015        1951        -1064     
  Lines         629433      283772      -345661     
  Branches       46717       41686        -5031     
====================================================
- Hits          471105      135774      -335331     
+ Misses        154965      145358        -9607     
+ Partials        3363        2640         -723     
Flag Coverage Δ
Debug 47.84616% <50.00000%> (-26.99977%) ⬇️
integration 18.04763% <50.00000%> (+0.00459%) ⬆️
production 47.84616% <50.00000%> (-0.00353%) ⬇️
test ?
unit 44.84340% <0.00000%> (-0.03101%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra merged commit 3983d44 into dotnet:main Aug 10, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 RC1 milestone Aug 10, 2024
@lonitra lonitra deleted the cursorfixx branch August 10, 2024 00:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants