Unhook the mouse down hook at the end of PropertyGridView.ProcessEnumUpAndDown #12508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeafShi1
added
the
waiting-review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12508 +/- ##
===================================================
+ Coverage 75.73242% 75.83103% +0.09860%
===================================================
Files 3153 3163 +10
Lines 635807 636411 +604
Branches 46975 47000 +25
===================================================
+ Hits 481512 482597 +1085
+ Misses 150870 150351 -519
- Partials 3425 3463 +38
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I proceeded to test the changes made in this PR and the problem seems to be solved:
|
Tanya-Solyanik
added
the
waiting-for-testing
...orms/src/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/PropertyGridView.cs
Show resolved
Hide resolved
|
No new issue was found with the private dlls |
LeafShi1
removed
the
waiting-for-testing
Tanya-Solyanik
added
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
LeafShi1
added
the
waiting-review
Tanya-Solyanik
removed
the
waiting-review
LeafShi1
deleted the
Fix_12434_UnHookMoseDown_AtTheEndOf_ProcessEnumUpAndDown
branch
LeafShi1
added a commit
to LeafShi1/winforms
that referenced
this pull request
Dec 9, 2024
…UpAndDown (dotnet#12508) * Unhook the mouse down hook at the end of PropertyGridView.ProcessEnumUpAndDown * Removing ? from code line "EditTextBox?.SelectAll();"
Tanya-Solyanik
pushed a commit
that referenced
this pull request
Jan 9, 2025
…r experience in dropdown type editors in property grid (#12605) Backport of #12508, #12431, #12356 and #12479 to release/9.0 Fixes #12607 NET10 Bugs: #12434, #12421, #12440, #12031 Bug Description There are four issues that occur when using the up/down keys to switch property values in the property page. When navigating to "Auto Size" dropdown using the up/down arrow keys, it is getting auto selected without hitting ENTER After using Tab to switch property values, then using the up/down keys to switch items in the drop-down box expanded by F4 will cause the drop-down box to collapse directly [Accessibility] When using up/down to toggle property value on edit text box, The Accessibility rectangle focuses on the entire property row instead of the original edit text box [Accessibility] Narrator cannot announce items correctly when switching the items by using up/down keyboard arrow that without expand the dropdown list panel Customer Impact PropertyGrid drop down type editor does not support conventional keyboard navigation. Usually, selection is committed when the ENTER key is pressed. However, in this case value is committed on the Down arrow press. Then the drop down list is expanded, the screen reader user might want to navigate through all values in the drop down using the arrows, on each arrow key press the new item should be presented (and announced) in the selection text box, however, the drop down is closed on the first arrow key. According to the accessibility SMEs, this is a major problem - the keyboard users are losing their work by committing a wrong value. Screen reader user don't get correct feedback when navigating through the drop down list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12434
Root cause:
After changing the value by pressing up/down keyboard directly in EditTextbox, the
EditTextBox.HookMouseDownwill be set to TrueThe stack trace:
then pressing
Alt+Downto open the DropDown list, and select a item, the CommitValue will be invoked.At this time,
EditTextBox.HookMouseDown = true. In HookMouseDown, theFocus()was invoked, so the DropDown list was collapsed.Proposed changes
EditTextBox.HookMouseDown = falseat the end of PropertyGridView.ProcessEnumUpAndDownCustomer Impact
Regression?
Risk
Screenshots
Before
Pressing Up/Down keyboard in drop-down list of property collapses dropdown directly.
After
When pressing the up/down keyboard in the property drop-down list, the drop-down menu will not be collapsed directly
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow