Skip to content

Conversation

@RussKie
Copy link
Contributor

@RussKie RussKie commented Aug 16, 2021

Resolves #5074

Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested a review from vlada-shubina August 16, 2021 10:15
@ghost ghost assigned RussKie Aug 16, 2021
Copy link
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Do you have some tests running for these templates to check if it works correctly for different combinations?

@RussKie
Copy link
Contributor Author

RussKie commented Aug 25, 2021

Do you have some tests running for these templates to check if it works correctly for different combinations?

This is a gap that I'm not sure how to bridge... Is there something you could suggest we borrow from dotnet/templating?

@RussKie RussKie closed this Aug 30, 2021
@RussKie RussKie deleted the fix_5074_templates_implicit_usings branch August 30, 2021 09:39
@RussKie
Copy link
Contributor Author

RussKie commented Aug 30, 2021

Replaced by #5547

@ghost ghost added the draft draft PR label Sep 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

draft draft PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update C# templates with global usings

2 participants