Enable nullability in DockEditor, ContentAlignmentEditor and SelectionPanelBase #9649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreddy-work
reviewed
Aug 3, 2023
| protected RadioButton CheckedControl | ||
| { | ||
| get => _checkedControl; | ||
| get => _checkedControl!; |
Member
There was a problem hiding this comment.
I do not have a real scenario here but forgiving null only propagate error somewhere else in this case and setter doesn't ensure it isn't null. Can you check if you can remove backing field here? Is it possible to enforce null check in this?
Contributor
Author
There was a problem hiding this comment.
The setter prevents us from removing the backing field. It ensures the value passed to it isn't null because it calls FocusCheckedControl which crashes with a NRE if CheckedControl is null. So my first version of the annotation of this property was RadioButton? with [DisallowNull]. But I realised that almost all the callsites then need a null forgiving operator, so I thought it was simpler to just do it the way it is here
dreddy-work
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
dreddy-work
previously approved these changes
Aug 3, 2023
Member
|
Please resolve conflict. |
dreddy-work
added
the
ready-to-merge
auto-merge was automatically disabled
August 4, 2023 08:27
Head branch was pushed to by a user without write access
dreddy-work
approved these changes
Aug 4, 2023
ghost
removed
the
ready-to-merge
dreddy-work
pushed a commit
that referenced
this pull request
Aug 4, 2023
* [main] Update dependencies from dotnet/runtime (#9648) * Update dependencies from https://github.com/dotnet/runtime build 20230802.13 Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 From Version 8.0.0-rc.1.23401.22 -> To Version 8.0.0-rc.1.23402.13 * Handle `ref` to `in` change (#9654) A number of Libarary APIs have had their parameters changed from `ref` to `in` (or `readonly ref`). This change modifies code that we control and disables the "passing ref to in" warning for the interop assembly until we can get microsoft/CsWin32#1014 resolved. This change requires a more current Roslyn build and as such I've updated it. Note that VS Intellisense does not support this new feature yet. You can filter out intellisense errors by selecting "Build Only" in the error pane in the meantime (this will not remove red squiggles unfortunately). --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Jeremy Kuhne <[email protected]> * [main] Update dependencies from dotnet/arcade (#9661) [main] Update dependencies from dotnet/arcade * [main] Update dependencies from dotnet/runtime (#9662) [main] Update dependencies from dotnet/runtime * Enable nullability in DockEditor, ContentAlignmentEditor and SelectionPanelBase (#9649) * annotate SelectionPanelBase * annotate DockEditor * annotate ContentAlignmentEditor --------- Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Jeremy Kuhne <[email protected]> Co-authored-by: halgab <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
SelectionPanelBaseDockEditorContentAlignmentEditorMicrosoft Reviewers: Open in CodeFlow