Added few tests for OpenFolderDialog #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
singhashish-wpf
approved these changes
May 5, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #129
Description
This PR adds a few tests for the upcoming OpenFolderDialog API.
It mostly derives from file dialog tests. Apart from that added a test for Multiselect functionality.
There are two ways in which common dialog tests are executed - one RunApplication mode, which runs an application and the second is RunConfigurationFile, which allows the test infra to interact with the dialog. I have created separate projects for each of them.
Added a total of 6 tests, out of which 5 are passing. 1 failure is similar to that in the OpenFileDialog test ( failing test is a copy of a test for OpenFileDialog ).
Here are the guidelines/process for adding tests for new public APIs : test-addition-guidelines
PS : As of now, I have not added the projects in root sln ( Microsoft.Dotnet.Wpf.Test.sln ) because it will break the build.
Steps for building this PR
Take the
FolderDialogTestsandOpenFolderDialogTestsproject nodes fromAppModel.slnand add them toMicrosoft.Dotnet.Wpf.Test.sln. Now follow the steps mentioned in the above test addition guideline link.Customer Impact
Allows developers to run tests on OpenFolderDialog
Regression
--
Testing
Built and ran the tests
Risk
Microsoft Reviewers: Open in CodeFlow