Remove ArrayLists from WPF / XPS to improve code and performance

[wstaelens]

wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/AlphaFlattener/Primitive.cs

Line 1999 in 89d172d

public ArrayList Children

ArrayList? why not List?

wpf/src/Microsoft.DotNet.Wpf/src/ReachFramework/AlphaFlattener/Flattener.cs

Line 101 in 89d172d

ArrayList children = canvas.Children;

wpf/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Markup/XamlStream.cs

Line 577 in 89d172d

ArrayList _readerBufferArrayList;

https://github.com/dotnet/wpf/search?l=C%23&q=arraylist

all versions

[IAmTheCShark]

My wild guess is that List<T> didnt exist when the code was written.
Also they are basically identical in terms of code, the only improvement here is getting rid of boxing in a few places, but mostly it wouldn't improve at all.

[wstaelens]

@IAmTheCShark just search arraylist VS list and you will find many reasons why it will boost performance.

WPF/XPS code should be made up-to-date for .net (core).

(My 1st hit: https://stackoverflow.com/a/59379803 )

[IAmTheCShark]

@IAmTheCShark just search arraylist VS list and you will find many reasons why it will boost performance.

WPF/XPS code should be made up-to-date for .net (core).

(My 1st hit: https://stackoverflow.com/a/59379803 )

Again, the only difference is when value types are involved (boxing), and that is not so often.
Look at your first Link when List<string> is compared to ArrayListin below the screenshots.