Skip to content

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Feb 6, 2025

Description

This PR aims to fix MilCodeGen which seems to be very outdated and it doesn't seem like it ever worked in this repo (It probably worked in the internal repo for Microsoft).

The goal of this PR is to fix MilCodeGen and Csp to be able to build and run MilCodeGen. I'll open other PRs to fix the templates to match the generated code and then other PRs which includes the modification to the generated code.

I cherry-picked the changes from #6135, reworked it to make it easier to use and updated the documentation.

Customer Impact

None, this is non-shipping code.

Regression

No.

Testing

Local build + I generated the code locally using #6135 rebased over this PR.

Risk

Low to none, this is non-shipping code and MilCodeGen already doesn't run so it can't get any worse.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested review from a team as code owners February 6, 2025 03:20
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Feb 6, 2025
@ThomasGoulet73 ThomasGoulet73 force-pushed the fix-milcodegen-and-csp-build branch from 6f9910c to ed4cd70 Compare February 6, 2025 03:23
@dipeshmsft dipeshmsft self-assigned this Feb 6, 2025
@ThomasGoulet73 ThomasGoulet73 mentioned this pull request Feb 6, 2025
@dipeshmsft
Copy link
Member

@ThomasGoulet73 I have reviewed the PR and left the comments. I am still to look into GenerateFiles.cmd, Resources.xml, Resources.xsd and related files, but I will be done by tomorrow.

@ThomasGoulet73
Copy link
Contributor Author

Thanks @dipeshmsft, I believe I've applied all your change requests and answered your questions. I also pulled main to fix the conflicts.

Let me know if there's anything else.

@dipeshmsft
Copy link
Member

Thanks @ThomasGoulet73 for the quick turnaround on the comments and feedback. I have reviewed the PR again, and I have only one concern that I have left in the comments. Apart from that this PR is good to go.

@ThomasGoulet73
Copy link
Contributor Author

Thanks @ThomasGoulet73 for the quick turnaround on the comments and feedback. I have reviewed the PR again, and I have only one concern that I have left in the comments. Apart from that this PR is good to go.

Great, I pushed a commit and answered your comment.

@dipeshmsft dipeshmsft merged commit 85319c2 into dotnet:main Feb 8, 2025
8 checks passed
@dipeshmsft
Copy link
Member

Thanks @ThomasGoulet73 for support on this PR. I will wait for subsequent PRs on MilCodeGen.

@ThomasGoulet73
Copy link
Contributor Author

Thanks @dipeshmsft.

P.S.: I opened #10429 to track the rest of the work.

@ThomasGoulet73 ThomasGoulet73 deleted the fix-milcodegen-and-csp-build branch February 8, 2025 04:43
@dipeshmsft dipeshmsft added this to the .NET 10 milestone Feb 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
@dipeshmsft dipeshmsft modified the milestones: .NET 10, 10.0.0 Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants