Skip to content

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Feb 8, 2025

Contributes to #10429

Description

Generates the code in WindowsBase using the changes from #10430.

I recommend reviewing only the last commit and with whitespace changes hidden, use this link.

Customer Impact

None, shouldn't affect customers.

Regression

No.

Testing

Local build + CI + I manually validated the generated code.

Risk

Low, there shouldn't be any functional changes.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested review from a team as code owners February 8, 2025 06:08
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Feb 8, 2025
@ThomasGoulet73
Copy link
Contributor Author

This PR is blocked by #10430.

@ThomasGoulet73 ThomasGoulet73 force-pushed the run-MilCodeGen-for-WindowsBase branch from be8df2a to 8e7f317 Compare February 11, 2025 05:57
@dipeshmsft dipeshmsft merged commit bacf186 into dotnet:main Feb 11, 2025
8 checks passed
@dipeshmsft
Copy link
Member

Thanks @ThomasGoulet73, I will go ahead to the next PR.

@dipeshmsft dipeshmsft added this to the .NET 10 milestone Feb 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
@dipeshmsft dipeshmsft modified the milestones: .NET 10, 10.0.0 Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants