In ClrObjectRuntime, move the object definition next to the code used #4044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only in exceptions do we need to use string splicing logic, which means that this string splicing code is wasteful in normal use
ghost
requested review from
pchaurasia14
added
the
Community Contribution
|
Hey @lindexi, does this PR have any performance implications? Any kind of improvement? |
|
@dipeshmsft Yes, normally, we don't need to alloc memory for qMethodName. |
dipeshmsft
approved these changes
Feb 6, 2023
|
Hey @lindexi, we are ready to take this PR. Can you go ahead and resolve the conflicts? Thanks a lot for your continued support. |
|
Thank you @dipeshmsft And I will fix it soon. |
Only in exceptions do we need to use string splicing logic, which means that this string splicing code is wasteful in normal use
|
Thanks @lindexi for your contribution and quick response. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only in exceptions do we need to use string splicing logic, which means that this string splicing code is wasteful in normal use