Removing xamltypemapper clearance from finally in compile function #7846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
Member
Where does this happen ?? |
dipeshmsft
approved these changes
Jun 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7439
Description
Removing call to XamlTyperMapper.Clear() function from finally block in compile function as the static members
HasInternalis refrenced at the later part of codeflow and it is unsafe to clear the static members at this point of time. That being said, XamlTypeMapper gets clear in the next iteration of call to compile function.Customer Impact
Application having user control with internal constructors will crash.
Regression
NA
Testing
In-progress
Risk
Assessing
Microsoft Reviewers: Open in CodeFlow