Fix sc Color.ToString() #7923
Merged
Fix sc Color.ToString() #7923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lindexi
approved these changes
Jun 14, 2023
rchauhan18
approved these changes
Jun 14, 2023
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/backport to release/7.0-staging |
|
Started backporting to release/7.0-staging: https://github.com/dotnet/wpf/actions/runs/5309158849 |
Contributor
|
oh my god |
Contributor
|
Thanks @miloush for the fix! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7918
Description
A recent removal of
StringBuildershad a bug in there causingColor.ToString()throwFormatException.This PR fixes the typo.
Customer Impact
Customers not taking this fix will continue experiencing exceptions when trying to display the textual representation of colors in scRGB color space.
Regression
Yes. #6275
Testing
Built using 8.0.0-preview.3.23174.8 and verified that the ToString() no longer throws for scRGB colors and the output is formatted correctly.
Risk
No risk, fixes regression in .NET 7.
Microsoft Reviewers: Open in CodeFlow