Refactor Configvalidator #2293
Merged
Refactor Configvalidator #2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
reviewed
Nov 1, 2023
Member
|
@larsbj1988 Just checking, are you still interested in pursuing this PR? |
Contributor
Author
Yes. Just need some time to do it. Will fix within a week 😊 |
Tratcher
reviewed
Nov 16, 2023
src/ReverseProxy/Configuration/RouteValidators/IRouteValidator.cs
Outdated
Show resolved
Hide resolved
src/ReverseProxy/Configuration/ClusterValidators/IClusterValidator.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Ross <[email protected]>
…ator.cs Co-authored-by: Chris Ross <[email protected]>
Tratcher
reviewed
Nov 20, 2023
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
Looks pretty good. Mostly style comments left.
src/ReverseProxy/Configuration/ClusterValidators/HealthCheckValidator.cs
Outdated
Show resolved
Hide resolved
src/ReverseProxy/Configuration/ClusterValidators/HealthCheckValidator.cs
Show resolved
Hide resolved
src/ReverseProxy/Configuration/ClusterValidators/ProxyHttpRequestValidator.cs
Outdated
Show resolved
Hide resolved
src/ReverseProxy/Configuration/RouteValidators/AuthorizationPolicyValidator.cs
Show resolved
Hide resolved
Member
|
Potential conflict with #2328 |
Tratcher
reviewed
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce Cognitive Complexity in Configvalidator class for readability and extensibility