Skip to content

Conversation

@mroberts91
Copy link
Contributor

Add contextual doc comments indicating that using AddForwarded or AddXForwarded header transforms will remove the other from the RequestTransforms when either is enabled. Without the comments, this may seem to be an unexpected behavior without reading the source code of the extension methods to understand the effect each method has on the other at runtime.

…rded header transforms will remove the other when enabled.
@MihaZupan MihaZupan added this to the YARP 2.2 milestone Jul 2, 2024
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MihaZupan MihaZupan enabled auto-merge (squash) July 2, 2024 14:06
@MihaZupan MihaZupan merged commit 4b0f664 into dotnet:main Jul 2, 2024
@mroberts91
Copy link
Contributor Author

Thank you

@MihaZupan MihaZupan added the Type: Documentation Improvements or additions to documentation label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants