Fixes the data type of the expected_size variable #2438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this patch changes the data type of the
expected_sizevariable from float to integer.The
expected_sizevariable could currently be a float whenbuilder.compression_rate()returns a float value, but I think it should be an integer becauseexpected_sizerepresents the size of aMemoryRecordsBuilderobject in bytes.P.S. I got a
test_memory_records_builderfailure on Python-3.13.b02 in Fedora Linux.https://bugzilla.redhat.com/show_bug.cgi?id=2290344
Thanks in advance,
Hirotaka
This change is