Fix many broken cargo tests #1509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.2.74 doesn't build with rustc 1.88.0. This also requires modifying some test cases that previously expected specific behavior when building older wasm-bindgen versions.
This test case creates a Cargo.toml fixture specifying version "0.3" of wasm-bindgen-test as a dependency, then reads the lockfile and checks the version of that dependency therein. It previously checked for a specific, hard-coded version of that dependency in the lock file, but that fails once the published package has been updated. Instead, we should check that the version in the lockfile matches the semver specified in Cargo.toml.
Documents preliminary steps that developers working on wasm-pack itself may need to take before `cargo test` can succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most, but not all, test failures mentioned in #1508 . There are still one or two different failures on macOS 15.5 depending on the rust version used.
Template
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨