Skip to content

Conversation

@AlexandreOuellet
Copy link

This adds the catalog names in front of fields and table when needed. It will most likely require more finetuning but is a working prototype

@VinceDPM
Copy link

VinceDPM commented Mar 2, 2020

We're interested in this feature being integrated into a future release of PyHive. Is there any reason (besides failed travis CI) that the PR was never approved?

@AlexandreOuellet
Copy link
Author

To be honest, I made this for work, created the PR and forgot about it. I can have a quick look to make it pass the flake8 issues

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

❌ Patch coverage is 54.83871% with 14 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@d19cb0c). Learn more about missing BASE report.
⚠️ Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
pyhive/sqlalchemy_presto.py 55.55% 5 Missing and 3 partials ⚠️
pyhive/presto.py 53.84% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #246   +/-   ##
=========================================
  Coverage          ?   92.46%           
=========================================
  Files             ?       14           
  Lines             ?     1553           
  Branches          ?      170           
=========================================
  Hits              ?     1436           
  Misses            ?       84           
  Partials          ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexandreOuellet
Copy link
Author

This is as far as I can get tonight. It's alright with python 3.6, but fails with 3.5, 3.4 and 2.7. Feel free to fork off of my branch if you want to contribute to it.

@VinceDPM
Copy link

VinceDPM commented Mar 3, 2020

Thanks, I found a similar str bug and made a PR against your branch that fixes the build for python 3.4/5, and added fix for python 2.7 syntax.

@VinceDPM VinceDPM mentioned this pull request Mar 10, 2020
Copy link
Contributor

@bkyryliuk bkyryliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to see the examples on how would it behave & add some unit tests

@cerodav
Copy link

cerodav commented Jul 29, 2020

Hi Could you give an example on how to create the engine and query multiple catalgoues ?

@laserkaplan
Copy link

I noticed that this repo currently says it's unsupported, but is there any way we would be able to get this PR merged and into another release? I also now have the need for the functionality here. Happy to help implement whatever tests are required to get this through.

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ Aleandre Ouellet
❌ AlexandreOuellet
❌ VinceDPM


Aleandre Ouellet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants