fix(files): Implement file upload renaming security fix from SA-CORE-2020-012 #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rthideaway
approved these changes
Nov 23, 2020
| // Validate the file entity against entity-level validation and field-level | ||
| // validators. | ||
| if (!$this->validate($file, $validators, $response)) { | ||
| return $response; |
There was a problem hiding this comment.
shouldn't we release the lock before returning response?
There was a problem hiding this comment.
nice, you just found a bug in core's FileUploadResource which we copied :)
|
I will merge this now and create a follow-up for the lock bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/sa-core-2020-012 also affects our custom file upload service.
We don't want to depend on REST module in Drupal core, so I duplicated the code from FileUploadResource and modified it to what we need.
Not really nice, but should cover the security fix and give us comprehensive file name coverage.
We don't need to report this to the Drupal security team because graphql's file upload service is not in any release yet and has just been introduced in #1112 .