Implement leaked metadata detection for QueryResultAssertionTrait #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds detection of leaked cacheability metadata to assertResults and assertErrors in the QueryResultAssertionTrait. The context is serialized in the error message because this is always possible and while serialized content isn't the most readable it provides the most robust method of easily showing what metadata was leaked. Fixes drupal-graphql#1206
|
Makes sense to me, thanks! |
chrfritsch
added a commit
to chrfritsch/graphql
that referenced
this pull request
Nov 24, 2021
* 8.x-4.x: fix(dataproducer): Fix language definition to be single value in entity reference producers (drupal-graphql#1241) docs(server): Improved class property descriptions feat(server): Add configurable validation security rules for introspection and query complexity (drupal-graphql#1244) tests(buffer): Fix ArryObject usage to not depend on Zend (drupal-graphql#1247) test(phpstan): Add missing return type hint fix(file-upldoad): Validate files in the correct order fix(DataProducer): Fix entity reference loading by language (drupal-graphql#1232) tests(assertions): Implement leaked metadata detection for QueryResultAssertionTrait (drupal-graphql#1207) tests(github): Switch testing to Drupal core 9.2.x (drupal-graphql#1215) chore(voyager): yarn audit security updates (drupal-graphql#1214) test(phpstan): Enable PHPStan run on PHP 8.0 (drupal-graphql#1211) refactor(executor): Replace deprecated AST::getOperation() with AST::getOperationAST() (drupal-graphql#1210) fix(executor): Remove swapped errors compatibility mode
klausi
pushed a commit
to klausi/graphql
that referenced
this pull request
Sep 21, 2023
…tAssertionTrait (drupal-graphql#1207) This adds detection of leaked cacheability metadata to assertResults and assertErrors in the QueryResultAssertionTrait. The context is serialized in the error message because this is always possible and while serialized content isn't the most readable it provides the most robust method of easily showing what metadata was leaked. Fixes drupal-graphql#1206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds detection of leaked cacheability metadata to assertResults and assertErrors
in the QueryResultAssertionTrait.
The context is serialized in the error message because this is always possible and while
serialized content isn't the most readable it provides the most robust method of easily
showing what metadata was leaked.
Fixes #1206