Skip to content

Conversation

@rthideaway
Copy link
Contributor

fixing #1165 correctly

@seanflahertyT4
Copy link

Hi, I'm sorry but what is the design intent of returning an empty array OR null? why isn't the element just removed from the list?

This is unexpected, breaking behaviour and a security vulnerability.

@seanflahertyT4
Copy link

since the default REVISIONS is LATEST, I suggest making the { status:"1" } filter a default condition as well.

query { nodeQuery(filter: {conditions: [ {field: "status", value: "1"} {field: "type", value: "content_type"} ]}, revisions: LATEST) { count } }

@klausi
Copy link
Contributor

klausi commented Dec 20, 2021

Thanks, looks like test coverage is missing here as well, adding the "needs tests" tag.

@klausi
Copy link
Contributor

klausi commented Feb 13, 2022

Continued in #1265

@klausi klausi closed this Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants