Skip to content

Extend entity url with absolute option #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 11, 2022
Merged

Extend entity url with absolute option #1291

merged 10 commits into from
Jul 11, 2022

Conversation

Cryt1c
Copy link
Contributor

@Cryt1c Cryt1c commented Jun 23, 2022 •
edited
Loading

Continuation of #1220

I have added an additional argument for the relationship type.

@joaogarin joaogarin requested a review from klausi July 8, 2022 06:00
@joaogarin joaogarin added the 4.x label Jul 8, 2022
klausi
klausi approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@klausi klausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. The test case is a bit weak since it does not really test anything, but should be good enough for this simple change.

src/Plugin/GraphQL/DataProducer/Entity/EntityUrl.php
* "entity" = @ContextDefinition("entity",
* label = @Translation("Entity")
* ),
* "rel" = @ContextDefinition("any",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data type should be string

@klausi klausi merged commit 1134c1d into drupal-graphql:8.x-4.x Jul 11, 2022
klausi added a commit that referenced this pull request Jul 11, 2022
@klausi
fix(EntityUrl): Fix context data type to be string (#1291)
923a322
@klausi
Copy link
Contributor

klausi commented Jul 11, 2022

I pushed a small follow-up to fix the context data type.

This was referenced Jul 11, 2022
Closed
Closed
@Cryt1c Cryt1c deleted the extend-entity-url-with-absolute-option branch July 11, 2022 13:34
klausi pushed a commit to klausi/graphql that referenced this pull request Sep 21, 2023
@Cryt1c @klausi
feat(EntityUrl): Extend entity url dataproducter with absolute option (…
4437f79 
…drupal-graphql#1291)
klausi added a commit to klausi/graphql that referenced this pull request Sep 21, 2023
@klausi
fix(EntityUrl): Fix context data type to be string (drupal-graphql#1291)
e00aa0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klausi klausi klausi approved these changes

Assignees

@Cryt1c Cryt1c

Labels

4.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cryt1c @klausi @joaogarin @rollki