Skip to content

Conversation

@sebas5384
Copy link
Contributor

Fixes #406

@fubhy
Copy link
Contributor

fubhy commented Oct 19, 2017

Annotation classes are not required anymore afaik.

@sebas5384
Copy link
Contributor Author

sebas5384 commented Oct 19, 2017

@fubhy didn't know that, I'm using Drupal 8.4 with Drupal Console 1.0.2 and PHP 5.6.27, when or where that requirement is not needed anymore?

@fubhy
Copy link
Contributor

fubhy commented Oct 20, 2017

@sebas5384 Not sure but with that setup you should not need it either. The command worked before without the annotation class. So if you can remove that part (while keeping the renaming to "graphql") that would be cool!

@fubhy fubhy merged commit 58ea895 into drupal-graphql:8.x-3.x Oct 20, 2017
@sebas5384
Copy link
Contributor Author

sebas5384 commented Oct 20, 2017

@fubhy sorry for the delay, but I'm glad you merge it already!
I'll test again without the use for annotation on other environments.

@sebas5384
Copy link
Contributor Author

@fubhy we tested in some other environments and it breaks cause of the missing use thing.

I guess, there's some miss match at the version from which you are working.

Given that, to avoid the breaking of Drupal console, we are going to need to maintain a patch to solve this issue till we figure it out what is missing here :/

@webexpert5
Copy link

I am also getting this error message
Setup: Drupal 8.4, PHP: 7.1 and Graphql version 8.x-3.0-alpha8

[Doctrine\Common\Annotations\AnnotationException]
[Semantical Error] The annotation "@DrupalCommand" in class Drupal\graphql\
Command\PersistQueryMapCommand was never imported. Did you maybe forget to
add a "use" statement for this annotation?

@fubhy
Copy link
Contributor

fubhy commented Oct 24, 2017

Strange. I am not getting this for some reason. Anyways, feel free to submit that as another PR. It doesn't hurt to have it in the code.

@sebas5384
Copy link
Contributor Author

@fubhy done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants