Skip to content

Conversation

rthideaway
Copy link
Contributor

We'd like to move some of our custom data producers to graphql module:

  • Current user
  • Entity query
  • Taxonomy load tree
  • Entity reference revisions (including entity revision buffer)

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #859 into 8.x-4.x will decrease coverage by 5.73%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-4.x     #859      +/-   ##
=============================================
- Coverage      66.77%   61.03%   -5.74%     
- Complexity       550      619      +69     
=============================================
  Files             91       96       +5     
  Lines           1276     1396     +120     
=============================================
  Hits             852      852              
- Misses           424      544     +120
Impacted Files Coverage Δ Complexity Δ
...GraphQL/DataProducer/Taxonomy/TaxonomyLoadTree.php 0% <0%> (ø) 3 <3> (?)
...c/Plugin/GraphQL/DataProducer/User/CurrentUser.php 0% <0%> (ø) 3 <3> (?)
...L/DataProducer/Images/EntityReferenceRevisions.php 0% <0%> (ø) 34 <34> (?)
src/GraphQL/Buffers/EntityRevisionBuffer.php 0% <0%> (ø) 14 <14> (?)
...Plugin/GraphQL/DataProducer/Entity/EntityQuery.php 0% <0%> (ø) 15 <15> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbd488...dd89077. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #859 into 8.x-4.x will decrease coverage by 5.73%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-4.x     #859      +/-   ##
=============================================
- Coverage      66.77%   61.03%   -5.74%     
- Complexity       550      619      +69     
=============================================
  Files             91       96       +5     
  Lines           1276     1396     +120     
=============================================
  Hits             852      852              
- Misses           424      544     +120
Impacted Files Coverage Δ Complexity Δ
...GraphQL/DataProducer/Taxonomy/TaxonomyLoadTree.php 0% <0%> (ø) 3 <3> (?)
...c/Plugin/GraphQL/DataProducer/User/CurrentUser.php 0% <0%> (ø) 3 <3> (?)
...L/DataProducer/Images/EntityReferenceRevisions.php 0% <0%> (ø) 34 <34> (?)
src/GraphQL/Buffers/EntityRevisionBuffer.php 0% <0%> (ø) 14 <14> (?)
...Plugin/GraphQL/DataProducer/Entity/EntityQuery.php 0% <0%> (ø) 15 <15> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbd488...dd89077. Read the comment docs.

@joaogarin
Copy link
Member

@rthideaway I dontt hink you tagged anyone for reviwing this. Can you ping someone? Some of these would be quite usefull to have inside graphql

@rthideaway
Copy link
Contributor Author

@joaogarin I didn't as I cannot assign a reviewer

@fubhy
Copy link
Contributor

fubhy commented Sep 16, 2019

Can you split up the resolver into seperate prs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants