Skip to content

Conversation

@SpadXIII
Copy link

EntityFieldPropertyDeriver overrides the parents defined in the GraphQLField-annotation. In RC2, the parents defined in the annotation were added to the array instead of overridden.

EntityFieldPropertyDeriver overrides the parents defined in the GraphQLField-annotation. In RC2, the parents defined in the annotation were added to the array instead of overridden.
@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #925 into 8.x-3.x will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             8.x-3.x     #925      +/-   ##
=============================================
- Coverage      79.09%   79.08%   -0.02%     
- Complexity      1290     1291       +1     
=============================================
  Files            192      192              
  Lines           3105     3108       +3     
=============================================
+ Hits            2456     2458       +2     
- Misses           649      650       +1
Impacted Files Coverage Δ Complexity Δ
...ugin/Deriver/Fields/EntityFieldPropertyDeriver.php 93.33% <75%> (-6.67%) 6 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038dc82...dc9f44f. Read the comment docs.

@pmelab pmelab merged commit 7d2b82c into drupal-graphql:8.x-3.x Oct 31, 2019
@SpadXIII SpadXIII deleted the patch-1 branch October 31, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants