Load translated referenced entities before array_filter and abstract logic in a trait #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #974 +/- ##
==========================================
Coverage ? 54.54%
Complexity ? 621
==========================================
Files ? 114
Lines ? 1562
Branches ? 0
==========================================
Hits ? 852
Misses ? 710
Partials ? 0
Continue to review full report at Codecov.
|
fubhy
requested changes
Feb 22, 2020
|
Thanks for this PR Dimitar! Looks good in general but I'd like to split up the function body into smaller reusable pieces and use a more descriptive function name. |
|
Abstracted also logic inside trait and added some comments to each method. |
# Conflicts: # src/Plugin/GraphQL/DataProducer/Field/EntityReference.php # src/Plugin/GraphQL/DataProducer/Field/EntityReferenceRevisions.php
…ntityReferenceLayoutRevisions
|
The patch works nicely for me. One thing that is a bit related: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logic for resolving translated entity references is loading the translated versions in order to check the access to them. But at the end the default language version is returned. This PR makes sure to pass the proper language version(s) into the
array_filterfunction that strips out the ones, where access is not given.