Parse deprecated versions. #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to issues like rust-lang/cargo#3124, we've found that the old parser was lenient in ways that the new parser isn't. We've analyzed all the crates on crates.io, and found the patterns that weren't working. This commit adds support back for those versions, but marks them as deprecated. Each of them had a different way in which they were incorrect, but resolved to some kind of correct constraint. So the deprecation strategy is this: 1. If a version fails to parse, check if it matches the deprecated pattern. 2. If it does, convert it to the real pattern. 3. Return an error that it's deprecated, and the error will contain the fixed-up version constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to issues like rust-lang/cargo#3124, we've
found that the old parser was lenient in ways that the new parser isn't.
We've analyzed all the crates on crates.io, and found the patterns that
weren't working.
This commit adds support back for those versions, but marks them as
deprecated. Each of them had a different way in which they were
incorrect, but resolved to some kind of correct constraint. So the
deprecation strategy is this:
pattern.
fixed-up version constraint.